This forum is a discussion about improving the "Password Manager - Remember, delete, change and import saved passwords in Firefox" article. If you'd like to participate, please register.

If you need help with Firefox, please ask a question.

"Login Manager" Needs change entry ... also "Show passwords" button change reverted in Fx44, Fx42 "Remember login" prompt, Import win-only

  • 37 Replies
  • Last reply by ideato
  1. AliceWyman 5055 posts
    Report Abuse

    Tonnes, I approved your pending revision and I made a new one that's pending review, to add Image:fx42SavedPasswordsUI under the "Viewing and deleting passwords" section:

    ;{for not fx42}[[Image:saved passwords 38]]{/for}{for =fx42}[[Image:fx42SavedPasswordsUI]]{/for}{for fx43}[[Image:fx43SavedLoginsUI]]{/for}

    I also changed their to the in the following sentence, since "this site" is singular ("its" would be another option):


    If you later change your mind and would like Firefox to ask you to save usernames and passwords for this site, you'll need to go into your Firefox Options and remove their entry from the Security panel exceptions list.

    Tonnes, I approved your pending revision and I made a new one that's pending review, to add Image:fx42SavedPasswordsUI under the "Viewing and deleting passwords" section: <nowiki>;{for not fx42}[[Image:saved passwords 38]]{/for}{for =fx42}[[Image:fx42SavedPasswordsUI]]{/for}{for fx43}[[Image:fx43SavedLoginsUI]]{/for}</nowiki> I also changed '''their''' to '''the''' in the following sentence, since "this site" is singular ("its" would be another option): ----- If you later change your mind and would like Firefox to ask you to save usernames and passwords for this site, you'll need to go into your Firefox Options and remove their entry from the [[Security and passwords settings|Security panel]] exceptions list.
  2. Tonnes 63 posts
    Report Abuse

    AliceWyman said

    One more change is needed. In Firefox 42 on Windows 7, the Saved Passwords UI also has an Import button, as shown in this screenshot I just uploaded.

    I noticed it but assumed it would not be worth changing it for 42 only. Great though. :)

    I also changed "their" to "the" in the following sentence, since "this site" is singular ( "its" would be another option) If you later change your mind and would like Firefox to ask you to save usernames and passwords for this site, you'll need to go into your Firefox Options and remove their entry from the Security panel exceptions list.

    I thought about it when editing, but since it’s about removing the usernames and passwords (for this site), similar to the first part of line 52 / all the time, I deliberately referred to them as their instead of it, and "the entry" may be unclear for what it refers to. Calling it "the site’s entry" would probably be another option. ;) Thoughts?

    Btw, I noticed multi-selection by either ctrl or shift is possibe when deleting an entry. Not sure if it’s worth mentioning that.

    ''AliceWyman [[#post-13124|said]]'' <blockquote>One more change is needed. In Firefox 42 on Windows 7, the Saved Passwords UI also has an Import button, as shown in [https://support.mozilla.org/en-US/gallery/image/24306 this screenshot I just uploaded]. </blockquote> I noticed it but assumed it would not be worth changing it for 42 only. Great though. :) <blockquote>I also changed "their" to "the" in the following sentence, since "this site" is singular ( "its" would be another option) <code>If you later change your mind and would like Firefox to ask you to save usernames and passwords for this site, you'll need to go into your Firefox Options and remove their entry from the [[Security and passwords settings|Security panel]] exceptions list.</code> </blockquote> I thought about it when editing, but since it’s about removing the ''usernames and passwords'' (for this site), similar to the first part of line 52 / all the time, I deliberately referred to them as ''their'' instead of ''it'', and "the entry" may be unclear for what it refers to. Calling it "the site’s entry" would probably be another option. ;) Thoughts? Btw, I noticed multi-selection by either ctrl or shift is possibe when deleting an entry. Not sure if it’s worth mentioning that.
  3. AliceWyman 5055 posts
    Report Abuse

    Tonnes said

    I thought about it when editing, but since it’s about removing the usernames and passwords (for this site), similar to the first part of line 52 / all the time, I deliberately referred to them as their instead of it, and "the entry" may be unclear for what it refers to. Calling it "the site’s entry" would probably be another option. ;) Thoughts?
    fx42Exceptions-SavedPasswords

    The entry you would be removing on the Exceptions list is the entry for the site, which is why I changed it from "their entry" to "the entry":

    If you later change your mind and would like Firefox to ask you to save usernames and passwords for this site, you'll need to go into your Firefox Options and remove the entry from the Security panel exceptions list.

    Yes, I agree we could change it to "the site’s entry".

    ^ I made an edit to my pending revision to make that minor change.

    ''Tonnes [[#post-13126|said]]'' <blockquote> I thought about it when editing, but since it’s about removing the ''usernames and passwords'' (for this site), similar to the first part of line 52 / all the time, I deliberately referred to them as ''their'' instead of ''it'', and "the entry" may be unclear for what it refers to. Calling it "the site’s entry" would probably be another option. ;) Thoughts? </blockquote> ;[[Image:fx42Exceptions-SavedPasswords]] The entry you would be removing on the Exceptions list is the entry for the site, which is why I changed it from "their entry" to "the entry": <code>If you later change your mind and would like Firefox to ask you to save usernames and passwords for this site, you'll need to go into your Firefox Options and remove '''the entry''' from the [[Security and passwords settings|Security panel]] exceptions list.</code> Yes, I agree we could change it to "the site’s entry". ^ I made an edit to my pending revision to make that minor change.
    Modified by AliceWyman on
  4. AliceWyman 5055 posts
    Report Abuse

    Tonnes said

    Btw, I noticed multi-selection by either ctrl or shift is possibe when deleting an entry. Not sure if it’s worth mentioning that.

    Forgot to reply to that. I would say no.

    Anyway, can you review my pending revision where I changed "the entry" to "the site's entry"? If it's OK we should mark the changes as ready to localize.

    ''Tonnes [[#post-13126|said]]'' <blockquote>Btw, I noticed multi-selection by either ctrl or shift is possibe when deleting an entry. Not sure if it’s worth mentioning that.</blockquote> Forgot to reply to that. I would say no. Anyway, can you review my pending revision where I changed "the entry" to "the site's entry"? If it's OK we should mark the changes as ready to localize.
  5. Tonnes 63 posts
    Report Abuse

    All should be fine so I approved it and cleared the Needs change entry. Thanks!

    All should be fine so I approved it and cleared the Needs change entry. Thanks!
  6. Underpass 712 posts
    Report Abuse

    Hello, sorry, I've checked both the new "for not fx42" and "for fx42" blocks but I don't seem to see so much difference.

    Why did you split the section in two blocks? Thanks.

    Hello, sorry, I've checked both the new "for not fx42" and "for fx42" blocks but I don't seem to see so much difference. Why did you split the section in two blocks? Thanks.
  7. Tonnes 63 posts
    Report Abuse

    Hi Underpass,

    The only differences are "Remember Password" and "Remember" (2x) and "Update Password" and "Update" (1x). An easy way to check such instances is copying both sections in e.g. files 1 and 2 and do a local diff. :)

    I think Alice split them because of an issue in the list that would otherwise arise.

    Hi Underpass, The only differences are "Remember Password" and "Remember" (2x) and "Update Password" and "Update" (1x). An easy way to check such instances is copying both sections in e.g. files 1 and 2 and do a local diff. :) I think Alice split them because of an issue in the list that would otherwise arise.
  8. AliceWyman 5055 posts
    Report Abuse

    I split the first section into {for not fx42} and {for fx42} blocks because I thought the changes that were needed were bigger then they actually turned out to be. We really only need one block in the first section, using {for} to make changes for fx42 and for not fx42:


    {note}'''Tip:''' Clicking outside of the Remember{for not fx42} Password{/for} prompt will hide it. To bring it back, just click the key icon on the left side of the location bar. If Firefox does not prompt you to save passwords, see the article [[Usernames and passwords are not saved]].{/note} In the prompt: * '''To have Firefox remember your username and password''', click on {for not fx42}{button Remember Password}{/for}{for fx42}{button Remember}{/for}. The next time you visit the website, Firefox will automatically enter your username and password for you. ** If you've stored the wrong username or password, just type the right one into the website and Firefox will prompt you to save it. To save the new username and password, click on {for not fx42}{button Update Password}{/for}{for fx42}{button Update}{/for}.


    I made a new revision that can be approved if others agree that the above would be better than separate blocks.

    I split the first section into {for not fx42} and {for fx42} blocks because I thought the changes that were needed were bigger then they actually turned out to be. We really only need one block in the first section, using {for} to make changes for fx42 and for not fx42: ----- <nowiki> {note}'''Tip:''' Clicking outside of the Remember{for not fx42} Password{/for} prompt will hide it. To bring it back, just click the key icon on the left side of the location bar. If Firefox does not prompt you to save passwords, see the article [[Usernames and passwords are not saved]].{/note} In the prompt: * '''To have Firefox remember your username and password''', click on {for not fx42}{button Remember Password}{/for}{for fx42}{button Remember}{/for}. The next time you visit the website, Firefox will automatically enter your username and password for you. ** If you've stored the wrong username or password, just type the right one into the website and Firefox will prompt you to save it. To save the new username and password, click on {for not fx42}{button Update Password}{/for}{for fx42}{button Update}{/for}. </nowiki> ----- I made a new revision that can be approved if others agree that the above would be better than separate blocks.
    Modified by AliceWyman on
  9. Underpass 712 posts
    Report Abuse

    Alice, of course I agree.

    But I also beg you not to mark revisions as ready for localization in cases like this. Thanks.

    Alice, of course I agree. But I also beg you not to mark revisions as ready for localization in cases like this. Thanks.
  10. AliceWyman 5055 posts
    Report Abuse

    Underpass said

    Alice, of course I agree. But I also beg you not to mark revisions as ready for localization in cases like this. Thanks.

    By "cases like this" I'm guessing you meant the many four recent changes marked ready for localization one after the other but sometimes it's hard for a reviewer to tell when an article is "ready". In this particilar case, there was an edit pending since Dec 27 I approved RFL on Jan 15 because I thought that another change wasn't needed until Fx45. Maybe Article review guidelines needs updating. Related discussions in the l10n forum, here and here.

    In this particular case I'm fine with whatever others decide. If Tonnes, Joni or another reviewer wants to approve my revision then marking it ready to localize (or not) is up to them.

    ''Underpass [[#post-13136|said]]'' <blockquote> Alice, of course I agree. But I also beg you not to mark revisions as ready for localization in cases like this. Thanks. </blockquote> By "cases like this" I'm guessing you meant the <s>many</s> <sub>four</sub> recent changes marked ready for localization one after the other but sometimes it's hard for a reviewer to tell when an article is "ready". In this particilar case, there was an edit pending since Dec 27 I approved RFL on Jan 15 because [https://support.mozilla.org/en-US/kb/password-manager-remember-delete-change-and-import/discuss/6338?page=1#post-13106 I thought] that another change wasn't needed until Fx45. Maybe [[Article review guidelines]] needs updating. Related discussions in the l10n forum, [https://support.mozilla.org/en-US/forums/l10n-forum/711618 here] and [https://support.mozilla.org/en-US/forums/l10n-forum/711632 here]. In this particular case I'm fine with whatever others decide. If Tonnes, Joni or another reviewer wants to approve my revision then marking it ready to localize (or not) is up to them.
    Modified by AliceWyman on
  11. AliceWyman 5055 posts
    Report Abuse

    ... and yet another change is needed:

    Looks like the new password "Import" for fx42 is Windows-only. See the first post I made in this thread.

    ... and yet another change is needed: Looks like the new password "Import" for fx42 is Windows-only. See the first post I made in this thread.
  12. Underpass 712 posts
    Report Abuse

    The problem is not the number of revisions but their *entity*.

    Ok, I'm going to wait until you've finished the changes, and maybe a day or two more.

    The problem is not the number of revisions but their *entity*. Ok, I'm going to wait until you've finished the changes, and maybe a day or two more.
  13. AliceWyman 5055 posts
    Report Abuse

    I made a new revision since Import passwords for fx42 is Windows-only ... and a second revision to change the related screenshots for mac, linux (needs review)

    I made a new revision since Import passwords for fx42 is Windows-only ... and a second revision to change the related screenshots for mac, linux (needs review)
  14. AliceWyman 5055 posts
    Report Abuse

    P.S. Under Viewing and deleting passwords: Instead of changing the screenshots for mac, linux and making To import passwords from Chrome or Internet Explorer, click {button Import} and follow the instructions in the wizard." show for windows only, we could still show the above along with the screenshot with the Import button, and just add a note similar to this:

    {for mac, linux} {note}Note: The Password Manager Import feature is currently available on Windows only.{/note}

    That would also help reduce any confusion that Mac and Linux users might have, since the article title is "Password Manager - Remember, delete, change and import saved passwords in Firefox". Otherwise we should probably rename the article to remove "import" from the title.

    I made a new revision based on the above.

    I also moved the note, To view passwords for a specific site (about View Saved Logins) to where it makes more sense.

    P.S. Under Viewing and deleting passwords: Instead of changing the screenshots for mac, linux and making '''To import passwords from Chrome or Internet Explorer''', click {button Import} and follow the instructions in the wizard." show for windows only, we could still show the above along with the screenshot with the Import button, and just add a note similar to this: {for mac, linux} {note}Note: The Password Manager Import feature is currently available on Windows only.{/note} That would also help reduce any confusion that Mac and Linux users might have, since the article title is "Password Manager - Remember, delete, change and import saved passwords in Firefox". Otherwise we should probably rename the article to remove "import" from the title. I made a new revision based on the above. I also moved the note, '''To view passwords for a specific site''' (about View Saved Logins) to where it makes more sense.
    Modified by AliceWyman on
  15. Tonnes 63 posts
    Report Abuse

    Alice: if it’s up to me and considering the change, approving and marking your last revision RFL is OK.

    Underpass: are you receiving emails for minor edits, or are your concerns about the amount of revisions? (Not sure what you mean by "entity"). It may be best to follow-up on that in this discussion.

    Alice: if it’s up to me and considering the change, approving and marking your last revision RFL is OK. Underpass: are you receiving emails for minor edits, or are your concerns about the amount of revisions? (Not sure what you mean by "entity"). It may be best to follow-up on that in [https://support.mozilla.org/en-US/forums/l10n-forum/711618 this discussion].
  16. AliceWyman 5055 posts
    Report Abuse

    Tonnes said

    Alice: if it’s up to me and considering the change, approving and marking your last revision RFL is OK.

    Thanks for checking my revision. I'll approve it myself and mark it RFL.

    ''Tonnes [[#post-13150|said]]'' <blockquote> Alice: if it’s up to me and considering the change, approving and marking your last revision RFL is OK. </blockquote> Thanks for checking my revision. I'll approve it myself and mark it RFL.
  17. Tonnes 63 posts
    Report Abuse

    I missed an excessive {/for} in line 19... However, it doesn’t break the article so won’t need a new RFL. Personally (and in general) I would mark such revision RFL though because approval was just done a short while ago so (almost) no-one will have it updated yet, and Underpass already noticed. ;)

    I missed an excessive {/for} in line 19... However, it doesn’t break the article so won’t need a new RFL. Personally (and in general) I would mark such revision RFL though because approval was just done a short while ago so (almost) no-one will have it updated yet, and Underpass already noticed. ;)
  18. ideato 567 posts
    Report Abuse

    Tonnes said

    I missed an excessive {/for} in line 19... However, it doesn’t break the article so won’t need a new RFL. Personally (and in general) I would mark such revision RFL though because approval was just done a short while ago so (almost) no-one will have it updated yet, and Underpass already noticed. ;)

    +1, done

    ''Tonnes [[#post-13157|said]]'' <blockquote> I missed an excessive {/for} in line 19... However, it doesn’t break the article so won’t need a new RFL. Personally (and in general) I would mark such revision RFL though because approval was just done a short while ago so (almost) no-one will have it updated yet, and Underpass already noticed. ;) </blockquote> +1, done
  1. 1
  2. 2